Skip to content

fix(list-view): always set a default template #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

edusperoni
Copy link
Collaborator

Also logs when we try to create a view without a valid template key

PR Checklist

What is the current behavior?

What is the new behavior?

This fixes an edge case where if you set nsTemplateKey it won't create the default template, meaning not using a templateSelector will break the ListView.

Up to discussion: the previous integration would silently ignore missing keys and create the default template instead. Should we do the same, add a flag (fallbackToDefaultTemplate) or just do what this PR introduces (log as an error)?

Also logs when we try to create a view without a valid template key
@cla-bot cla-bot bot added the cla: yes label Jul 5, 2021
@NathanWalker NathanWalker merged commit 44d0d88 into main Jul 6, 2021
@NathanWalker NathanWalker deleted the fix/lview-edge-cases branch July 6, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants