fix(list-view): always set a default template #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also logs when we try to create a view without a valid template key
PR Checklist
What is the current behavior?
What is the new behavior?
This fixes an edge case where if you set
nsTemplateKey
it won't create the default template, meaning not using a templateSelector will break the ListView.Up to discussion: the previous integration would silently ignore missing keys and create the default template instead. Should we do the same, add a flag (
fallbackToDefaultTemplate
) or just do what this PR introduces (log as an error)?